Remove InternalEventHandler
#2952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkrasnitski
force-pushed
the
internal-event-handler
branch
from
d6925f1
to
bc0c705
Compare
arqunis
approved these changes
Aug 26, 2024
arqunis
added
enhancement
GnomedDev
pushed a commit
to GnomedDev/serenity
that referenced
this pull request
Oct 7, 2024
Since having both a regular event handler and a raw handler at the same time is now supported, the `InternalEventHandler` enum is no longer needed to ensure mutual exclusivity. Additionally, there was a subtle bug introduced when the `Both` variant was added: ratelimit events and shard stage update events would not be dispatched because the conditionals to dispatch those events only checked for the `Normal` variant. Inlining the regular/raw event handler fields improves ergonomics and fixes said bug.
GnomedDev
pushed a commit
to GnomedDev/serenity
that referenced
this pull request
Oct 20, 2024
Since having both a regular event handler and a raw handler at the same time is now supported, the `InternalEventHandler` enum is no longer needed to ensure mutual exclusivity. Additionally, there was a subtle bug introduced when the `Both` variant was added: ratelimit events and shard stage update events would not be dispatched because the conditionals to dispatch those events only checked for the `Normal` variant. Inlining the regular/raw event handler fields improves ergonomics and fixes said bug.
GnomedDev
pushed a commit
that referenced
this pull request
Oct 20, 2024
Since having both a regular event handler and a raw handler at the same time is now supported, the `InternalEventHandler` enum is no longer needed to ensure mutual exclusivity. Additionally, there was a subtle bug introduced when the `Both` variant was added: ratelimit events and shard stage update events would not be dispatched because the conditionals to dispatch those events only checked for the `Normal` variant. Inlining the regular/raw event handler fields improves ergonomics and fixes said bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since having both a regular event handler and a raw handler at the same time is now supported, the
InternalEventHandlerenum is no longer needed to ensure mutual exclusivity. Additionally, there was a subtle bug introduced when theBothvariant was added: ratelimit events and shard stage update events would not be dispatched because the conditionals to dispatch those events only checked for theNormalvariant. Inlining the regular/raw event handler fields improves ergonomics and fixes said bug.