Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: option to disable NaptTrigger file generation #6

Closed
ZacSweers opened this issue Aug 12, 2022 · 1 comment · Fixed by #7
Closed

Feature request: option to disable NaptTrigger file generation #6

ZacSweers opened this issue Aug 12, 2022 · 1 comment · Fixed by #7

Comments

@ZacSweers
Copy link
Contributor

ZacSweers commented Aug 12, 2022 •
edited
Loading

Would you be open to a pull request to allow disabling of napttrigger file generation? I have two reasons in mind:

  • I would feel more sure about kotlinc's incremental compilation accounting for these files if they weren't ephemeral. Gradle + ephemeral files as inputs has bitten us in the past quite often.
  • Some of our projects already have java files in them anyway, so it's unnecessary in those
@sergei-lapin sergei-lapin mentioned this issue Aug 12, 2022
Merged
@sergei-lapin
Copy link
Owner

Hey @ZacSweers, great idea! I think this PR #7 resolves the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

provide ability to disable napt trigger generation sergei-lapin/napt
2 participants
@ZacSweers @sergei-lapin