Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint.sh is broken on macOS due to cat -n behavior #62

Closed
maksimov opened this issue Dec 3, 2016 · 1 comment
Closed

lint.sh is broken on macOS due to cat -n behavior #62

maksimov opened this issue Dec 3, 2016 · 1 comment

Comments

@maksimov
Copy link
Contributor

maksimov commented Dec 3, 2016

I've been following the contributors' guide and I couldn't get past make lint command as it was giving an error on a vanilla source code. One of the issues is with testing the output of the likes of golint where it is expected to be empty. However echo -n "$OUT" printed out -n instead of nothing, which was then considered as an error condition.

I've tested a substitute command echo "$OUT\c" which does the same thing and works both on macOS and Linux. I will send a PR.

zimmski added a commit that referenced this issue Dec 3, 2016
@zimmski
Copy link
Collaborator

zimmski commented Dec 3, 2016

If you put "Fixes #62" in the commit description of a commit, the issue gets automatically closed if the PR is merged.

@zimmski zimmski closed this as completed Dec 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants