Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZeroR is broken #1

Closed
nirvdrum opened this issue Aug 1, 2009 · 2 comments
Closed

ZeroR is broken #1

nirvdrum opened this issue Aug 1, 2009 · 2 comments
Assignees

Comments

@nirvdrum
Copy link
Contributor

nirvdrum commented Aug 1, 2009

ZeroR chooses the first class value it comes across, not the most frequently accessed one. The test suite is a bit flawed in that the first class value also happens to be the most frequently accessed one.

The core problem is that no frequency is ever calculate so every class value looks like it has a frequency of 1.

I've fixed the problem on this branch:
http://github.com/nirvdrum/ai4r/tree/fix_zeror

With this commit:
ca6a404

@SergioFierens
Copy link
Owner

Patched.
Took a while, but I finally pulled it :)

@nirvdrum
Copy link
Contributor Author

Heh. No worries. I guess I could have issued a pull request. This predates all the fun stuff GitHub has added in the past three years.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants