Skip to content

Commit e1998b3

Browse files
authored
chore: drop node 4 EOL, add node 10 🎉 (#1556)
Node 4 you were the beginning of a golden age of node. I loved you and will miss you.
1 parent 131a939 commit e1998b3

File tree

3 files changed

+19
-40
lines changed

3 files changed

+19
-40
lines changed

.travis.yml

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -19,24 +19,24 @@ env:
1919
global:
2020
- secure: "L+AGMJc5NAsuym+xzB4FWj0c2rCobosixkoxLBhDBVkLiYsMtfS9y1w8Xz0pbWKJnJAH9tfwHluu5aX2qYk2HbreSyNzy8hbPW+9RbSyAQexeiZG4mLuDEz0xvlpCCQBsS1OfMypQk0/JvL4oA9B/xasrpkeVuPI7dwAz2WcFms="
2121
matrix:
22-
- TRAVIS_NODE_VERSION="4"
23-
- TRAVIS_NODE_VERSION="4" ARCH="x86"
2422
- TRAVIS_NODE_VERSION="6"
2523
- TRAVIS_NODE_VERSION="6" ARCH="x86"
2624
- BINARY_BUILDER="true" TRAVIS_NODE_VERSION="8"
2725
- BINARY_BUILDER="true" TRAVIS_NODE_VERSION="8" ARCH="x86"
2826
- TRAVIS_NODE_VERSION="9"
2927
- TRAVIS_NODE_VERSION="9" ARCH="x86"
28+
- TRAVIS_NODE_VERSION="10"
29+
- TRAVIS_NODE_VERSION="10" ARCH="x86"
3030
matrix:
3131
exclude:
32-
- os: osx
33-
env: TRAVIS_NODE_VERSION="4" ARCH="x86"
3432
- os: osx
3533
env: TRAVIS_NODE_VERSION="6" ARCH="x86"
3634
- os: osx
3735
env: BINARY_BUILDER="true" TRAVIS_NODE_VERSION="8" ARCH="x86"
3836
- os: osx
3937
env: TRAVIS_NODE_VERSION="9" ARCH="x86"
38+
- os: osx
39+
env: TRAVIS_NODE_VERSION="10" ARCH="x86"
4040

4141
before_install:
4242

@@ -57,9 +57,6 @@ before_install:
5757
- if [[ $TRAVIS_OS_NAME == "linux" ]]; then export CXX=g++-4.8; fi
5858
- $CXX --version
5959

60-
# upgrade npm if on node 4 as npm2 doesn't like our dev peer deps
61-
- if [[ $TRAVIS_NODE_VERSION == "4" ]]; then npm install -g npm; fi
62-
6360
# Cleanup the output of npm
6461
- npm config set progress false
6562
- npm config set spin false
@@ -89,12 +86,7 @@ install:
8986
- npm install --build-from-source
9087

9188
script:
92-
# linting no longer works on node 4
93-
- >
94-
if [[ $TRAVIS_NODE_VERSION != "4" ]]; then
95-
npm run lint
96-
fi;
97-
89+
- npm run lint
9890
- node ./
9991
- npm test
10092

README.md

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -83,18 +83,18 @@ In addition to reading the [article mentioned above](http://www.voodootikigod.co
8383
### Platform Support
8484
`serialport` supports NodeJS v4 and upwards. For versions 0.10 and 0.12, use `serialport@4`. The platforms, architectures and Node versions that `serialport` supports are the following;
8585

86-
| Platform / Arch | Node v4.x | Node v6.x | Node v8.x | Node v9.x |
87-
| --- | --- | --- | --- | --- |
88-
| Linux / ia32 |||||
89-
| Linux / x64 |||||
90-
| Linux / ARM v6¹ |||||
91-
| Linux / ARM v7¹ |||||
92-
| Linux / ARM v8¹ |||||
93-
| Linux / MIPSel¹ |||||
94-
| Linux / PPC64¹ |||||
95-
| Windows² / x86 |||||
96-
| Windows² / x64 |||||
97-
| OSX³ / x64 |||||
86+
| Platform / Arch | Node v4.x | Node v6.x | Node v8.x | Node v9.x | Node v10.x |
87+
| --- | --- | --- | --- | --- | --- |
88+
| Linux / ia32 ||||||
89+
| Linux / x64 ||||||
90+
| Linux / ARM v6¹ ||||||
91+
| Linux / ARM v7¹ ||||||
92+
| Linux / ARM v8¹ ||||||
93+
| Linux / MIPSel¹ ||||||
94+
| Linux / PPC64¹ ||||||
95+
| Windows² / x86 ||||||
96+
| Windows² / x64 ||||||
97+
| OSX³ / x64 ||||||
9898

9999
¹ ARM, MIPSel and PPC64¹ platforms are not currently part of our testing or build matrix, but are known to work.
100100

appveyor.yml

Lines changed: 2 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -6,30 +6,19 @@ environment:
66
secure: iDcAJCYgJK4tffyzEHbMVR8DatJcIN8eY0h29p9JQkl43TcEcm6Z6JLOBpGDk1MJ
77

88
matrix:
9-
- nodejs_version: "4"
109
- nodejs_version: "6"
1110
- binary_builder: "true"
1211
nodejs_version: "8"
1312
- nodejs_version: "9"
13+
- nodejs_version: "10"
1414

1515
platform:
1616
- x86
1717
- x64
1818

19-
# Dropping support for node 4 on 32 windows because it has isuses with ssl certs and npm
20-
matrix:
21-
exclude:
22-
- platform: x86
23-
nodejs_version: "4"
24-
25-
2619
install:
2720
- ps: Update-NodeJsInstallation (Get-NodeJsLatestBuild $env:nodejs_version) $env:platform;
28-
# upgrade npm if on node 4 as npm2 doesn't like our dev peer deps
2921
- ps: >
30-
if ($env:nodejs_version -eq "4") {
31-
npm install -g npm | Write-Host;
32-
}
3322
npm config set progress false
3423
npm config set spin false
3524
@@ -66,9 +55,7 @@ build_script:
6655

6756
test_script:
6857
- ps: >
69-
if ($env:nodejs_version -ne "4") {
70-
npm run lint
71-
}
58+
npm run lint
7259
node ./
7360
7461
# If we run npm test in powershell it'll have the wrong encoding so we have to do it like this

0 commit comments

Comments
 (0)