feat: add eslint mocha #1922
Merged
feat: add eslint mocha #1922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I committed an exclusive test, that shouldn’t happen.
reconbot
commented
Aug 26, 2019
| it('cannot be tested as we have no test ports') | ||
| return | ||
| } | ||
|
|
||
| describe('of 2 minutes of running 1k writes', () => { | ||
| if (process.version.match('v0.10.')) { |
There was a problem hiding this comment.
not necessary any longer
| @@ -164,7 +164,7 @@ describe('SerialPort', () => { | |||
| }) | |||
|
|
|||
| it('allows optional options', function(done) { | |||
| this.port = new SerialPort('/dev/exists', done) | |||
| this.port = new SerialPort('/dev/exists', () => done()) | |||
There was a problem hiding this comment.
lets eslint mocha know for sure we're calling done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I committed an exclusive test, that shouldn’t happen. This will prevent that.