fix tiocmget method
#61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method used the ioctl return value rather than the reference argument when constructing the returned bitflags
|
Nice find, confirmed that arg is used as an out result https://elixir.bootlin.com/linux/v5.13.18/source/drivers/tty/tty_io.c#L2529 |
jessebraham
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method used the
ioctlreturn value rather than the reference out argument when constructing the returned bitflagsI noticed the problem when trying to use the
read_ring_indicatormethod in a unix project and I was just getting a result of zero. I tested using the rawioctlmethod and realized the return is actually provided by the reference out argument.