-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Master/Slave WebUI modifications #152
Conversation
Interesting PR, looks good! But wouldn't it be a better idea to shut off the webserver on the slave devices? I can imagine the /update endpoint makes sense for updating the software, and the telnet debugging might make sense, but all other stuff doesn't? Why would you look at the webserver of the slave device anyways? |
Yes /update is definitely needed but also the / and /settings endpoints are still quite useful: these allow to visually (or in home assistant integration) to check the status of the slave (car connected / charging stopped / waiting for solar .. etc). Master does not report slave status, so no other practical way of accessing this information other than looking at the display. [ On the other hand disabling part of the writeable /settings api on slave would make sense I think, but in order to do so it would be probably better to first have a method allowing to change the master/slave mode remotely ? ] |
I make it a point to have installation dependent parameters only modifiable at the LCD display; like MaxMains, MaxCircuit etc. Agree on keeping /settings, although a lot of them would be irrelevant... From the webserver EVSE window I only see "Connected" and "State" as useful info. I think "OverrideCurrent" would not be valid for a Slave, perhaps StartTime/StopTime/Repeat although this should be tested on a slave... Am I missing something? |
For "dynamically" read "remotely" . |
Ok could you please adapt your PR so that it still exports loadbl to the REST API, and if loadbl >=2 then the webserver will only show b) the Control box , with Actions reboot/update/raw data. I think that is what we agree on, right? |
This looks promising! I do have a question: We have 2 electric cars which are both completely drained and both hooked up to their EVSEs. Is above function possible? Or is it with this PR that both EVSES will be in the same mode, so that both cars are charging (which results in lower charge rate, since i'm fuse limited). |
All EVSE's are always in the same mode (Normal, Smart, Solar), but I think it is possible to put a EVSE "OFF" (=access denied) while the other is charging. You would have to test this yourself! |
Will do! Thanks for your reply, i'll see what i can make in HA to do some "smart" selecting. |
@jaroslawp This would mean we need an on/off button in the webinterface of the slave... |
Let me check this - it should work (I can switch master to normal/off while slave stays what master told it to be - solar/smart .. but not sure if this really works as expected for charging .. need to test that - and other way around too) |
Sure, will have a look at this, additional question: conntactor 2 should be visible on master or there too it cannot be used in master/slave config ? |
No, Contactor2 cannot be used when loadbl != 0 (so master/slave config) |
Just removing some trailing spaces/tabs, this sometimes gets in the way of people using IDE's.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work, removed some trailing spaces but all fine!
This PR makes webui changes for master/slave(s) setups:
note: modifications via API are still possible.
in a master/slave(s) setup charging mode / amperage / etc modifications should be done only on master which propagates changes to slave(s) via modbus: current web interface allows to perform changes also on slaves .. which results in non-working and/or inconsistent setup of the system (communication errors/slave not charging connected EV .. etc)