Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds client and util #1522

Merged

Conversation

daizhenyu
Copy link
Collaborator

@daizhenyu daizhenyu commented May 27, 2024

What type of PR is this?

Feature.

What this PR does / why we need it?

Tool class, client, and abstract xdshandler of the xds service discovery module

Which issue(s) this PR fixes?

Fixes #1515

Does this PR introduce a user-facing change?

No

Checklist

  • Make sure there is a GitHub_issue related with this PR before you start working on it.
  • Make sure you have squashed your change to one single commit.
  • GitHub Actions works fine in this PR.

Copy link

codecov bot commented May 27, 2024

Codecov Report

Attention: Patch coverage is 37.26708% with 101 lines in your changes are missing coverage. Please review.

Flag Coverage Δ Complexity Δ
unittests 43.07% <37.26%> (+0.03%) 181.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ Complexity Δ
...n/java/io/sermant/core/service/ServiceManager.java 9.37% <ø> (ø) 0.00 <0.00> (ø)
...in/java/io/sermant/core/service/ServiceConfig.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...plement/service/xds/entity/XdsServiceInstance.java 50.00% <50.00%> (+50.00%) 0.00 <0.00> (ø)
.../io/sermant/core/service/xds/config/XdsConfig.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...mant/implement/service/xds/cache/XdsDataCache.java 70.00% <40.00%> (+70.00%) 0.00 <0.00> (ø)
...ment/service/xds/utils/XdsProtocolTransformer.java 84.84% <84.84%> (ø) 0.00 <0.00> (?)
...ermant/implement/service/xds/client/XdsClient.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...mant/implement/service/xds/handler/XdsHandler.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)

... and 7 files with indirect coverage changes

@daizhenyu daizhenyu force-pushed the develop-xds-service-discover branch 2 times, most recently from 56b2b80 to bfe99d3 Compare May 29, 2024 00:47
hanbingleixue
hanbingleixue previously approved these changes May 29, 2024
provenceee
provenceee previously approved these changes May 29, 2024
Signed-off-by: daizhenyu <1449308021@qq.com>
@daizhenyu daizhenyu dismissed stale reviews from provenceee and hanbingleixue via a39631f May 29, 2024 07:53
@daizhenyu daizhenyu force-pushed the develop-xds-service-discover branch from bfe99d3 to a39631f Compare May 29, 2024 07:53
@Sherlockhan Sherlockhan merged commit 0218446 into sermant-io:develop May 30, 2024
279 of 280 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supports xDS protocol to communicate with the Control Plane of Service Mesh
5 participants