Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds handler and service #1527

Merged

Conversation

daizhenyu
Copy link
Collaborator

@daizhenyu daizhenyu commented May 30, 2024

What type of PR is this?

Feature.

What this PR does / why we need it?

the xds handler and service of xds service module

Which issue(s) this PR fixes?

Fixes #1515

Does this PR introduce a user-facing change?

No

Checklist

  • Make sure there is a GitHub_issue related with this PR before you start working on it.
  • Make sure you have squashed your change to one single commit.
  • GitHub Actions works fine in this PR.

@daizhenyu daizhenyu force-pushed the develop-xds-service-discover branch 3 times, most recently from e154077 to eeaa3a8 Compare June 3, 2024 13:09
hanbingleixue
hanbingleixue previously approved these changes Jun 4, 2024
Signed-off-by: daizhenyu <1449308021@qq.com>
@daizhenyu daizhenyu force-pushed the develop-xds-service-discover branch from b6188f7 to 8700bab Compare June 4, 2024 02:51
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 78.83212% with 29 lines in your changes missing coverage. Please review.

Flag Coverage Δ Complexity Δ
unittests 43.18% <78.83%> (+0.11%) 181.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ Complexity Δ
...mant/implement/service/xds/cache/XdsDataCache.java 92.85% <100.00%> (+22.85%) 0.00 <0.00> (ø)
...mant/implement/service/xds/handler/CdsHandler.java 94.11% <94.11%> (ø) 0.00 <0.00> (?)
...mant/implement/service/xds/handler/XdsHandler.java 68.75% <40.00%> (+68.75%) 0.00 <0.00> (ø)
...mant/implement/service/xds/handler/EdsHandler.java 82.35% <82.35%> (ø) 0.00 <0.00> (?)
...service/xds/discovery/XdsServiceDiscoveryImpl.java 78.12% <78.12%> (ø) 0.00 <0.00> (?)
...mant/implement/service/xds/XdsCoreServiceImpl.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)

... and 26 files with indirect coverage changes

@Sherlockhan Sherlockhan merged commit 6b2582d into sermant-io:develop Jun 4, 2024
278 of 279 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supports xDS protocol to communicate with the Control Plane of Service Mesh
4 participants