Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review urls structure #1

Closed
gsouf opened this issue Apr 5, 2016 · 1 comment
Closed

Review urls structure #1

gsouf opened this issue Apr 5, 2016 · 1 comment
Assignees

Comments

@gsouf
Copy link
Member

gsouf commented Apr 5, 2016

  • Think about a common interface instead of UrlArchive
  • Review the relations between url/and urls that can generate requests (consider moving GoogleUrl::generateRequest away)
  • Review the url factory (currently the constructor is used, that's not flexible)
  • SerpUrlInterface should extend some UrlInterface
@gsouf gsouf self-assigned this Apr 5, 2016
@gsouf
Copy link
Member Author

gsouf commented Apr 14, 2016

The constructor was frozen for the factory. It's good because it allows url to remain a standard thing. If we need different way to construct url for search engines the best will be some special factories. For instance: Google::Url(...);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant