Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pyproject migration #110

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Pyproject migration #110

wants to merge 3 commits into from

Conversation

bastiencyr
Copy link

Should close #109

@bastiencyr
Copy link
Author

Oupsi, it seems like I have an issue with my PR. Don't accept it

@bastiencyr bastiencyr force-pushed the pyproject_migration branch 2 times, most recently from 8d398be to 95e0b5e Compare October 18, 2023 11:48
@bastiencyr
Copy link
Author

It's ok

@bastiencyr bastiencyr force-pushed the pyproject_migration branch 2 times, most recently from 167ea1b to 7947e7b Compare March 14, 2024 14:23
remi-braun
remi-braun reviewed Mar 14, 2024
View reviewed changes
.flake8
@@ -0,0 +1,4 @@
# compatibility black and flake8
[flake8]
max-line-length = 88
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

max-line-length = 200 si tu peux 😇 88 c'est trop peu j'aime pas

Copy link
Author

@bastiencyr bastiencyr Mar 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

En réalité ça ne change rien, la limite de 88 est la limite par défaut dans black qui n'a pas été changé dans eoreader. On respecte donc deja 88 comme longueur maximale avec Black, c'est pour ça que les tests de pré commits sont passés sans erreur.

@remi-braun
Copy link
Member

Ajouter la section :

[tool.typos]
files.extend-exclude = ["*.ipynb", "*.html", ".git/*"]
default.extend-ignore-re = ["_.*_", "\"\\w*\"", "PN", ", fo", "FRE", "THR", "T60HTE", "_BA"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remi-braun remi-braun remi-braun left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use pyproject.toml file
2 participants
@bastiencyr @remi-braun