Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap in separate file and output folder create automatically if not exists #24

Merged
merged 1 commit into from
Sep 8, 2016
Merged

Bootstrap in separate file and output folder create automatically if not exists #24

merged 1 commit into from
Sep 8, 2016

Conversation

cgalvarez
Copy link

closes #19. For details about the enhacement this PR implements, please, read the issue #19.

It should not break previous functionality. Please, anyone interested give it a test 😉

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 71.115% when pulling 6f8f165 on cgalvarez:new/boot_tasks into b0b6a8e on serut:master.

@codecov-io
Copy link

codecov-io commented Sep 8, 2016

Current coverage is 69.65% (diff: 60.00%)

Merging #24 into master will decrease coverage by 0.17%

@@             master        #24   diff @@
==========================================
  Files            19         20     +1   
  Lines           537        547    +10   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            375        381     +6   
- Misses          162        166     +4   
  Partials          0          0          

Powered by Codecov. Last update 02f037d...737b33d

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 71.115% when pulling d484c01 on cgalvarez:new/boot_tasks into b0b6a8e on serut:master.

export default Boot = {
startup() {
// Create reports output folder if not exists
let outputFolder = path.resolve(Conf.COVERAGE_APP_FOLDER, `.${path.sep}${Conf.COVERAGE_EXPORT_FOLDER}`);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

path.join(Conf.COVERAGE_APP_FOLDER, Conf.COVERAGE_EXPORT_FOLDER) can make the job

@serut
Copy link
Owner

serut commented Sep 8, 2016

Nothing more to say, it's nearly perfect ! Great job @cgalvarez !

@cgalvarez
Copy link
Author

Nice catch with the mkdirp exception!

I prefer path.resolve because users can use relative paths for COVERAGE_APP_FOLDER or the output key in the settings, like ../../myCoverageFolder. path.join() simply concatenates the two provided strings, while path.resolve() resolves and provides a final absolute path.

If you prefer path.join(), I can change that.

@serut
Copy link
Owner

serut commented Sep 8, 2016

Not really, path.join is not just a concatenation !

path.join('/foo', 'bar', 'baz/asdf', 'quux', '..')
// returns '/foo/bar/baz/asdf'

@cgalvarez
Copy link
Author

There you have it, @serut! Updated and rebased. Thanks for teaching me something new about path.join() 😉

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 69.653% when pulling 737b33d on cgalvarez:new/boot_tasks into 02f037d on serut:master.

@serut
Copy link
Owner

serut commented Sep 8, 2016

As always, it's perfect ! Thank you @cgalvarez !

@serut serut merged commit 1029458 into serut:master Sep 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output folder is not automatically created for the report type out_coverage
4 participants