-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bootstrap in separate file and output folder create automatically if not exists #24
Conversation
Current coverage is 69.65% (diff: 60.00%)@@ master #24 diff @@
==========================================
Files 19 20 +1
Lines 537 547 +10
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 375 381 +6
- Misses 162 166 +4
Partials 0 0
|
export default Boot = { | ||
startup() { | ||
// Create reports output folder if not exists | ||
let outputFolder = path.resolve(Conf.COVERAGE_APP_FOLDER, `.${path.sep}${Conf.COVERAGE_EXPORT_FOLDER}`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
path.join(Conf.COVERAGE_APP_FOLDER, Conf.COVERAGE_EXPORT_FOLDER)
can make the job
Nothing more to say, it's nearly perfect ! Great job @cgalvarez ! |
Nice catch with the I prefer If you prefer |
Not really, path.join is not just a concatenation !
|
There you have it, @serut! Updated and rebased. Thanks for teaching me something new about |
As always, it's perfect ! Thank you @cgalvarez ! |
closes #19. For details about the enhacement this PR implements, please, read the issue #19.
It should not break previous functionality. Please, anyone interested give it a test 😉