Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coverage verbosity #27

Closed
wants to merge 1 commit into from
Closed

Fix coverage verbosity #27

wants to merge 1 commit into from

Conversation

cgalvarez
Copy link

Description

The verbosity for coverage reports doesn't work because of undefined constants:

  • The default options for report generation use an undefined property Log.COVERAGE_VERBOSE. A constant COVERAGE_VERBOSE is exported in server/context/log.js, but it's not implemented as a property of Log. Since Log is a named export, this constant doesn't work like the others from Conf, and that's why that constant is undefined there.
  • An undefined property Conf.IS_COVERAGE_VERBOSE is used when generating a JSON summary report and when getting options through HTTP.

Motivation and Context

Get the coverage verbosity working.

How Has This Been Tested?

I noticed it was not working when looking at the stdout output after executing COVERAGE_VERBOSITY=1.

You will see that the messages related to coverage report generation starting with export coverage using the following format... always report verbose: false before applying this PR.

Testing environment:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@codecov-io
Copy link

Current coverage is 69.59% (diff: 75.00%)

Merging #27 into master will decrease coverage by 0.05%

@@             master        #27   diff @@
==========================================
  Files            20         20          
  Lines           547        546     -1   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits            381        380     -1   
  Misses          166        166          
  Partials          0          0          

Powered by Codecov. Last update 1029458...4cd9a9f

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 69.597% when pulling 4cd9a9f on cgalvarez:fix/verbosity into 1029458 on serut:master.

@serut
Copy link
Owner

serut commented Sep 12, 2016

Can you please create another pull request that point this branch https://github.com/serut/meteor-coverage/tree/dev-1.0.0 ? Otherwise you're right. ;-)

@serut serut closed this Sep 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants