some es5 to es6, coverage improvement and fix script commands #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serut
reviewed
Sep 21, 2016
| @@ -361,8 +356,8 @@ Why? When a browser opens the client side of your application, this package inte | |||
| - type: the type of report you want to create inside your `COVERAGE_APP_FOLDER` | |||
|
|
|||
| - Default: `coverage`, used to dump the coverage object in a file because when there are several types of test, we want to merge results, and the server reloads between each one. | |||
| - Allowed values: `cobertura`, `html`, `json`, `json-summary`, `lcov`, `teamcity`, `text`, `text-lcov`, `text-summary`, `lcovonly`, `coverage`, `remap` | |||
| - **Not working values:** `clover`, `cobertura`, `lcov`, `text`, `text-lcov`, PR welcome | |||
| - Allowed values: `cobertura`, `coverage`, `html`, `json`, `json-summary`, `lcov`, `lcovonly`, `remap`, `teamcity`, `text`, `text-lcov`, `text-summary` | |||
There was a problem hiding this comment.
The "not working" values are listed in "Allowed values" too. I should remove then cobertura, text-lcov, lcov, text and teamcity.
serut
reviewed
Sep 21, 2016
| @@ -112,18 +121,12 @@ instrumentClientJs = function (params, req, res, next) { | |||
| } | |||
| }; | |||
|
|
|||
|
|
|||
| let noop = function () {}; | |||
| export default Handlers = { | |||
There was a problem hiding this comment.
sadness... You optimized some legacy code. Handlers is not exposed anymore if Conf.IS_ACTIVE === false, so it does not require this mechanism
There was a problem hiding this comment.
So I can remove all the export...
|
All right for me. |
Current coverage is 69.86% (diff: 81.25%)@@ dev-1.0.0 #38 diff @@
===========================================
Files 22 21 -1
Lines 774 730 -44
Methods 0 0
Messages 0 0
Branches 0 0
===========================================
- Hits 588 510 -78
- Misses 186 220 +34
Partials 0 0
|
added 2 commits
September 21, 2016 21:20
serut
added a commit
that referenced
this pull request
Sep 21, 2016
* warn user when invalid .coverage.json * fix details page on html report with package test * two new exclusions for client side * bootstrap in separate file * fix not considered source map path patterns * generic glob patterns for exclusions * publishing workspace - wip * fix coverage verbosity * Update the readme with --settings usage + add some changes to @cgalvarez pull requests #26 #22 + reliability tests for client instrumentation script * Deploy 0.9.6 with - new configuration file - internal behavior fixed - new readme * Improve client errors and improve SourceMap.alterSourceMapPaths * Update README.md * Update README.md * Fix SourceMap sources paths * Remove old check inside coverage-data.js that existed when source maps where not reliable + lint + still a bug with client coverage that is not correcty exported in reports * fix four new source pattern and cover all test-packages perms (location and pkg quantity) * fix four new source pattern and cover all test-packages perms (location and pkg quantity) * new/remap * Edit the configuration file to remove 1 test from coverage + improve readme.md * Remove legacy code used by meteor-coverage to override wrong paths that we had before. more aggressive way than #36 * merge #37 * some es5 to es6, coverage improvement and fix script commands (#38) * some es5 to es6, coverage improvement and fix script commands * remove legacy code and fix readme info * revert handlers export * don't run ghost test * set spacejam as devdep * fix script commands with new spacejam syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some coverage improvement and some changes from es5 to es6.