feat(lambda-at-edge): support custom headers (with caveats) #662
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues: #587
Caveats: because of the way the default handler is currently architected (using S3 origin + origin response), any path that hits the S3 origin has its
request.uri
rewritten to the S3 path. This includes SSG pages, SSG data requests, public files, etc. Because of this, to have a custom header on these paths, you will need to specify the S3 key rather than the path. This is different from Next.js.For example: if you have an SSG page at path
/my-page
, you will need to specify the S3 key as the header source innext.config.js
, which will probably be something like/my-page.html
.Also, you can't add headers to
next/static/*
orstatic/*
paths, as those do not have origin handlers attached to them.In the future we may improve/fix this to be more in line with Next.js (e.g by possibly getting rid of the S3 origin and having the origin request handler make requests to S3 directly).
Tests
Added unit and e2e tests.