Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync subscription CORS configuration #328

Closed
mthenw opened this issue Oct 2, 2017 · 0 comments
Closed

Sync subscription CORS configuration #328

mthenw opened this issue Oct 2, 2017 · 0 comments

Comments

@mthenw
Copy link
Contributor

mthenw commented Oct 2, 2017

This is a Feature Proposal

Right now the event gateway allows all methods, headers, origins

handler := &http.Server{
Addr: ":" + strconv.Itoa(int(config.Port)),
Handler: cors.AllowAll().Handler(router),
ReadTimeout: 3 * time.Second,
WriteTimeout: 3 * time.Second,
}

CORS configuration should be per HTTP subscription. HTTP subscription should allow specifying additional cors field with the following structure (and default values):

{
  "cors": {
    "origins": [], // default "*"
    "methods": [], // default ["GET", "POST"]
    "headers": [],  // default ["Content-Type", "Authorization"]
    "allowCredentials": false // default "false"
  }
}

origins is an array but actually, it should return only matched origin in the request. See #16.

Similar or dependent issues:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant