-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Providers concept in the codebase. #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthenw
changed the title
[WIP] Introduce Providers concept in the codebase.
Introduce Providers concept in the codebase.
Mar 16, 2018
@mthenw Can you please do linting in separate PR's next time please 😄 |
@elsteelbrain yeah, sorry for that, VSCode did that for me. Just ignore README :) |
RaeesBhatti
approved these changes
Mar 19, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
I gonna merge this one and setup CodeCov instead of Coveralls. They have weird configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation
Right now there is no concept of providers in the codebase, it's only in configuration API. Calling AWS Lambda or HTTP endpoint is implemented in Function struct (https://github.com/serverless/event-gateway/blob/master/function/function.go) as
callAWSLambda
orcallHTTP
private functions. Depending on provider type defined in a function configuration adequate function is called.Downsides of that approach:
callAWSLambda
method)Proposed solution
function
package definesProvider
interface that provider need to implementfunction
package definesProviderLoader
interface that returnsProvider
instance configured based on JSON blob (configuration)function
package exposesRegisterProvider
function that expects provider type and provider loader. During function create (unmarshaling) adequate loader is fetched and based on JSON config it returns Provider instance which is attached to function instance.Each provider needs to register itself in init() function.
Thanks to that