Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix payload normalization in http.request events. Closes #434 #459

Merged
merged 1 commit into from
Jun 8, 2018

Conversation

mthenw
Copy link
Contributor

@mthenw mthenw commented Jun 8, 2018

What did you implement:

Closes #434

How did you implement it:

When we moved from HTTP event to http.request event as CloudEvent the normalization need to happen also for the Body in the event

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@codecov
Copy link

codecov bot commented Jun 8, 2018

Codecov Report

Merging #459 into master will increase coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #459     +/-   ##
=========================================
+ Coverage   66.06%   66.17%   +0.1%     
=========================================
  Files          32       32             
  Lines        1877     1883      +6     
=========================================
+ Hits         1240     1246      +6     
  Misses        585      585             
  Partials       52       52
Impacted Files Coverage Δ
event/http.go 100% <100%> (ø) ⬆️
event/event.go 78.12% <100%> (+0.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c89d5c...1e3fde2. Read the comment docs.

@mthenw mthenw merged commit 83d3405 into master Jun 8, 2018
@mthenw mthenw deleted the fix-normal branch June 8, 2018 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant