Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement missing interface methods in plugin logger #482

Merged
merged 1 commit into from
Jul 11, 2018

Conversation

mthenw
Copy link
Contributor

@mthenw mthenw commented Jul 11, 2018

hclog interface changed two days ago causing EG build to fail.

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@codecov
Copy link

codecov bot commented Jul 11, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@5f94b72). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #482   +/-   ##
=========================================
  Coverage          ?   70.73%           
=========================================
  Files             ?       35           
  Lines             ?     2180           
  Branches          ?        0           
=========================================
  Hits              ?     1542           
  Misses            ?      574           
  Partials          ?       64

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f94b72...10a6c1b. Read the comment docs.

@mthenw mthenw merged commit 7944da3 into master Jul 11, 2018
@mthenw mthenw deleted the fix-plugin-loger branch July 11, 2018 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant