Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Closes #448
How did you implement it:
This is a basic, non-prod setup, as it lacks some features, like RBAC for etcd and Event Gateway or TLS for etcd.
More details regarding etcd installation https://github.com/coreos/etcd-operator/tree/master/doc/user.
I think the question is if we want to leave the initial implementation like this (just for playing around with EG on K8s), or it should be as much prod-ready as possible at the start.
Currently, there's only one external service (LoadBalancer), exposing both config and events ports. Probably a better options would be to have 2 services with ingress in front. The problem is that events api doesn't expose a health check endpoint.
How can we verify it:
Todos:
Is this ready for review?: YES
Is it a breaking change?: NO