Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding in proper router processing #488

Merged
merged 4 commits into from
Jul 24, 2018
Merged

Conversation

sebito91
Copy link
Contributor

What did you implement:

Revert space parsing in the router package. This was not handling IP addresses when they are provided instead of a valid space name.

How did you implement it:

Revert a fix from #485

How can we verify it:

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: YES

@sebito91 sebito91 self-assigned this Jul 24, 2018
@sebito91 sebito91 requested a review from mthenw July 24, 2018 15:50
@codecov
Copy link

codecov bot commented Jul 24, 2018

Codecov Report

Merging #488 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #488      +/-   ##
==========================================
+ Coverage   70.77%   70.84%   +0.06%     
==========================================
  Files          37       37              
  Lines        2190     2195       +5     
==========================================
+ Hits         1550     1555       +5     
  Misses        576      576              
  Partials       64       64
Impacted Files Coverage Δ
router/path_hosted.go 83.33% <100%> (+11.9%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4be89f...77c0f0c. Read the comment docs.

@mthenw mthenw merged commit c563910 into serverless:master Jul 24, 2018
@sebito91 sebito91 deleted the router_update branch July 25, 2018 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants