Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use modules in go example instead of dep #648

Merged
merged 1 commit into from
Sep 20, 2021

Conversation

hkolvenbach
Copy link
Contributor

I tried to follow the go + aws example (see issue #647) and hit a few roadblocks. This PR allows to compile the example again, although I don't think the package structure is very "go-like".

Signed-off-by: Hanno Kolvenbach hannokolvenbach@gmx.de

Signed-off-by: Hanno Kolvenbach <hannokolvenbach@gmx.de>
@mnapoli
Copy link
Contributor

mnapoli commented Sep 20, 2021

Thank you. I'm not familiar with go, so I can't judge the "go-like" structure and I can't help unfortunately.

I would still say that a working example is better than a broken one, so I would merge that for now (to improve things immediately). @medikoo WDYT?

@medikoo
Copy link

medikoo commented Sep 20, 2021

@mnapoli I'm totally +1. I also, unfortunately, do not have that much experience in Go, so I guess we have to trust the community

Copy link
Contributor

@mnapoli mnapoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 then

@hkolvenbach
Copy link
Contributor Author

I think no matter of the structure, it will still help go developers get started. I assume Go developers using the example would reorganize the go code anyway, as soon as it gets a bit more involved. The important part is to see how it interacts with serverless and the Makefile

@mnapoli
Copy link
Contributor

mnapoli commented Sep 20, 2021

Merging, per discussion.

@mnapoli mnapoli merged commit 72b9dbd into serverless:master Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants