Multiple claims for authorizer break body mapping template

[pisaacs]

This is a Bug Report

Description

Setting multiple claims for an authorizer breaks the body mapping template.

For bug reports:

• What went wrong?
  Received the following error from API Gateway: {"message": "Could not parse request body into json: Unexpected character (\',\' (code 44)): was expecting double-quote to start field name\n at...

• What did you expect should have happened?
  Body mapping template to correctly parse claim fields.

• What was the config you used?
  The below:

...
    events:
      - http:
          path: person
          method: post
          cors: true
          integration: lambda
          authorizer:
            arn: ${self:custom.apiGatewayUserPoolAuthorization}
            claims:
              - email
              - name
....

• What stacktrace or error message from your provider did you see?
  Received the following from API gateway: {"message": "Could not parse request body into json: Unexpected character (\',\' (code 44)): was expecting double-quote to start field name\n at...

Additional Data

With two claims, the body mapping template for application/x-www-form-urlencoded gets configured as the below. Two commas appear between the fields.

.....   
 "cognitoPoolClaims" : {
       "email": "$context.authorizer.claims.email",,"name": "$context.authorizer.claims.name",
       "sub": "$context.authorizer.claims.sub"
    },
.....

• Serverless Framework Version you're using: 1.5.0
• Operating System: darwin

[kidsil]

Temporary Fix: when the second claim is removed (- name) it works fine.

[pisaacs]

It's not a fix if you have to remove something you need 😉. The temporary fix is to update the body mapping template after a deploy (which would then enable access to all claim fields).

[kidsil]

I guess you're right, but since for my solution I didn't really need anything more than the Email, it worked for me. On Jan 28, 2017 4:40 PM, "pisaacs" <notifications@github.com> wrote: It's not a fix if you have to remove something you need 😉. The temporary fix is to update the body mapping template after a deploy (which would then enable access to all claim fields). — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#3088 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJdRiyDh9b-9rG-MO4N6kxrf2aP2pkEks5rW2GAgaJpZM4LhVg9> .

[shasti421]

We are also running into this. Is the fix available in a release ?

[pmuens]

Hey @shasti421 we need to review and test the provided fix in order to include it in a release.

Have you had the time to test it? If so, does it resolve the issue for you?