Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build multi-arch controller images #153

Merged
merged 2 commits into from
Aug 5, 2022
Merged

Conversation

scothis
Copy link
Contributor

@scothis scothis commented Aug 4, 2022

By default we build the controller for all architectured supported by
the default base image gcr.io/distroless/static:nonroot. Including:

  • linux/arm64
  • linux/arm
  • linux/ppc64le
  • linux/s390x
  • linux/amd64

At development time, a subset can be built by setting KO_PLATFORMS:

KO_PLATFORMS=linux/amd64 make deploy

Resolves #150

Signed-off-by: Scott Andrews andrewssc@vmware.com

By default we build the controller for all architectured supported by
the default base image `gcr.io/distroless/static:nonroot`. Including:
- linux/arm64
- linux/arm
- linux/ppc64le
- linux/s390x
- linux/amd64

At development time, a subset can be built by setting KO_PLATFORMS:

```
KO_PLATFORMS=linux/amd64 make deploy
```

Signed-off-by: Scott Andrews <andrewssc@vmware.com>
@scothis scothis requested review from baijum and a team August 4, 2022 22:13
Copy link
Member

@baijum baijum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Scott Andrews <andrewssc@vmware.com>
@scothis scothis merged commit f4c659c into servicebinding:main Aug 5, 2022
@scothis scothis deleted the multi-arch branch August 5, 2022 01:26
sadlerap pushed a commit to sadlerap/service-binding-runtime that referenced this pull request Aug 24, 2022
By default we build the controller for all architectured supported by
the default base image `gcr.io/distroless/static:nonroot`. Including:
- linux/arm64
- linux/arm
- linux/ppc64le
- linux/s390x
- linux/amd64

At development time, a subset can be built by setting KO_PLATFORMS:

```
KO_PLATFORMS=linux/amd64 make deploy
```

Signed-off-by: Scott Andrews <andrewssc@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create multi-architecture container images
2 participants