Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating specification #7

Merged
merged 5 commits into from
Mar 30, 2020
Merged

Updating specification #7

merged 5 commits into from
Mar 30, 2020

Conversation

arthurdm
Copy link
Member

@arthurdm arthurdm commented Mar 24, 2020 •
edited
Loading

As discussed in today's interlock, this PR adds the following:

  • the usage of a service ID as a prefix to the binding data being mounted (or optionally injected as env vars by implementations)

@arthurdm arthurdm requested a review from navidsh March 24, 2020 20:23
@arthurdm
Copy link
Member Author

cc @sbose78

@sbose78
Copy link
Contributor

sbose78 commented Mar 25, 2020

Could you expand this to a different PR

the addition of a service discovery annotation in bindable resources, allowing tools to quickly discover them and making it easy to create ServiceBinding CRs

I would like to detail this out a bit differently.

@arthurdm
Copy link
Member Author

Sure @sbose78 - I now placed that update in PR #9

@sbose78
Copy link
Contributor

sbose78 commented Mar 27, 2020

Thanks, let me review!

navidsh
navidsh approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@navidsh navidsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@arthurdm arthurdm merged commit b965c20 into master Mar 30, 2020
@arthurdm arthurdm deleted the updateSchema branch April 24, 2020 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navidsh navidsh navidsh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arthurdm @sbose78 @navidsh