Add working support for EditorConfig #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should be in the root directory - this file does not get parsed, and the root file throws errors.
The existing contents of this file threw an error before, so I've taken the real .editorconfig file and moved it here to prevent errors being thrown.
|
On which OS are you working on? |
|
Well that's weird... I installed the package via Composer on OS X in to a Laravel installation. The .editorconfig file was not a symlink, just a plain text file. I just tried reinstalling the repository and now it appears as a symlink. No idea what happened there, but false alarm! In my haste to help out I didn't notice the original file was a symlink on GitHub, hence I deleted it in my pull request and had never realised. |
|
No problem. Anyway thanks for your help, I appreciate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PhpStorm (and presumably other editors too), the existing
.editorconfigfile was throwing an error in the IDE:As such, I've copied the contents of the
editorconfigfile from the/supportdirectory in to the root directory, and deleted the old file (which wasn't being read anyway, as it was not preceded with a.).