Support PHP 8.1+ #63
Merged
Support PHP 8.1+ #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop support for unsupported PHP versions. Fix deprecations in DOMElement. Add return types where known. Use Rector for majority of PHP updates. Bump version to 1.3.0.
|
Also resolves #62 |
|
Hi Ezra, thank you very much for your awesome contribution. It seams almost perfect to me. Due to the breaking nature of the changes (we drop support for PHP versions < 8), accordingly with the semantic versioning, we must release a major version. Please update the merge request to mark fluidxml as version 2.0.0. Given that, we should be ready to go. |
Update PHP versions in configs/CI
|
@daniele-orlando done 🚀 I've updated the CI/test configs to use the new PHP versions and tested against our production App too. Though Scrutinizer still seems to have an issue authenticating between Github and composer. |
This was referenced Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relatively blind update, to bring up to date.