Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core-foundation-sys shouldn't have changed version at all #96

Closed
tomaka opened this issue Jan 28, 2017 · 6 comments
Closed

Core-foundation-sys shouldn't have changed version at all #96

tomaka opened this issue Jan 28, 2017 · 6 comments

Comments

@tomaka
Copy link
Contributor

tomaka commented Jan 28, 2017

Because its Cargo.toml contains a links attribute, it is impossible to use core-foundation-sys v0.2 and core-foundation-sys v0.3 in the same project.

There is absolutely no reason why the version of core-foundation-sys should match the version of core-foundation.

@tomaka
Copy link
Contributor Author

tomaka commented Jan 28, 2017

It's too late now anyway, but it's a heads up for the next time.
I'm tired of fixing semver issues all the time. Now I have decided to report breakages to library owners.

@tomaka tomaka closed this as completed Jan 28, 2017
@tomaka
Copy link
Contributor Author

tomaka commented Jan 28, 2017

Hopefully the 24 people who watch this repo will be aware of this and will reject a PR that bumps core-foundation-sys.

@nox
Copy link
Contributor

nox commented Jan 28, 2017

I am not sure why you employ such a tone to convey your annoyance, and this is not a "semver issue". While it seems this could have been 0.2.4, doing a breaking bump doesn't break semver.

I assume you are fed up because of rust-windowing/glutin#853, but this wouldn't have happened if glutin had said core-foundation = "0.2.3" and not core-foundation = "0". Just make sure to reject a PR that depends on crates with a "0" version constraint.

@tomaka
Copy link
Contributor Author

tomaka commented Jan 28, 2017

@nox It has nothing to do with that but with the links attribute in the Cargo.toml.

@nox
Copy link
Contributor

nox commented Jan 28, 2017

No, core-foundation 0.3 was selected by Cargo in glutin only because Cargo does weird stuff with a single digit "0" version. Had both winit and core-graphics said 0.2, none of them would have used 0.3 and no two different versions of core-foundation would have been used at the same time.

@nox nox mentioned this issue Jan 28, 2017
@tomaka
Copy link
Contributor Author

tomaka commented Jan 28, 2017

I'm not talking about glutin's breakage here. It's totally glutin's fault and my fault for accepting a PR in the past that did = "0".

I'm opening this because we can't bump to core-foundation 0.3 without causing breakages in the entire ecosystem.

jdm pushed a commit that referenced this issue Feb 1, 2018
Add support for CGEvent value fields

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-graphics-rs/96)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants