Fix build on iOS #392
Merged
Fix build on iOS #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdm
approved these changes
Jun 26, 2020
|
@bors-servo r+ |
|
📌 Commit 9ae9c5e has been approved by |
|
☀️ Test successful - checks-travis |
|
@jdm woah, that's the fastest response I've ever seen! Would it be possible to get this released? |
|
Published 0.19.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#365 broke iOS, since
bitflagswas used despitebitflagsonly being included on macOS. Since it looks like theCGGradientAPI is supported on iOS as well, I fixed this by just removing the#[cfg(target_os = "macos")]line onextern crate bitflags.If I made a follow-up PR that adds iOS to CI, would that be welcome?