Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bitflags to 2 #549

Merged
merged 1 commit into from Apr 9, 2024
Merged

Update bitflags to 2 #549

merged 1 commit into from Apr 9, 2024

Conversation

burtonageo
Copy link
Contributor

Splits out the bitflags part of #545

@jdm
Copy link
Member

jdm commented May 19, 2023

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 0fb387a has been approved by jdm

@bors-servo
Copy link
Contributor

⌛ Testing commit 0fb387a with merge 048c24a...

bors-servo added a commit that referenced this pull request May 19, 2023
Update `bitflags` to 2.2.1

Splits out the `bitflags` part of #545
@bors-servo
Copy link
Contributor

💔 Test failed - checks-github

@bors-servo
Copy link
Contributor

☔ The latest upstream changes (presumably b009c87) made this pull request unmergeable. Please resolve the merge conflicts.

@daxpedda daxpedda mentioned this pull request Aug 8, 2023
@mrobinson mrobinson changed the title Update bitflags to 2.2.1 Update bitflags to 2 Apr 6, 2024
@mrobinson
Copy link
Member

This causes semver checks to start failing because fn from_bits_unchecked(...) is no longer exposed on bitflags types.

@mrobinson
Copy link
Member

I have rebaesed this PR, so assuming it passes all CI jobs I'll land it. The only substantive change I have made to the original version is to specify bitflags = "2" for the version instead of the exact version. This should make it slightly more compatible with other projects that use different versions of bitflags.

@mrobinson mrobinson added this pull request to the merge queue Apr 9, 2024
Merged via the queue into servo:main with commit abbcc1e Apr 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants