Upgrade to bitflags 2 #667
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
force-pushed
the
bitflags-2
branch
2 times, most recently
from
9191897
to
fe51d30
Compare
mrobinson
reviewed
Apr 9, 2024
| .downcast::<CFNumber>() | ||
| .unwrap() | ||
| .to_f64() | ||
| .unwrap(); |
There was a problem hiding this comment.
It looks like this code is unrelated?
|
It contains code to make the tests pass on macOS 14 (which includes my dev machine). That still seems useful? |
Yes, it could definitely be useful. Is it related to the bitflags changes though? Would you mind opening a new PR with these changes separating it out from the bitflags work? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A rebased version of #549 (retaining authorship from the OP).
cc @mrobinson following up on your plan from #521 (comment).