Skip to content
This repository has been archived by the owner on Jan 26, 2024. It is now read-only.

Add Bluetooth device support #1

Merged
merged 4 commits into from
Mar 12, 2016
Merged

Add Bluetooth device support #1

merged 4 commits into from
Mar 12, 2016

Conversation

Manishearth
Copy link
Member

Moved from servo/servo#9839

r? @larsbergstrom


This change is Review on Reviewable

@dati91
Copy link
Contributor

dati91 commented Mar 11, 2016

CC @larsbergstrom

@larsbergstrom
Copy link
Contributor

Do we need to add something like:

addons:
  apt:
    packages:
    - libdbus-1-dev

To the .travis.yml file in order for this to pass tests?

@larsbergstrom
Copy link
Contributor

Rebased against master and trying my fix.

@larsbergstrom
Copy link
Contributor

Reviewed 3 of 3 files at r1.
Review status: 3 of 4 files reviewed at latest revision, all discussions resolved.


Comments from the review on Reviewable.io

@larsbergstrom
Copy link
Contributor

lgtm

r? @Manishearth (for the .travis.yml change)

@Manishearth
Copy link
Member Author

@bors-servo r=larsbergstrom,Manishearth

@Manishearth
Copy link
Member Author

@bors-servo r+

@bors-servo
Copy link

📌 Commit bad1b50 has been approved by Manishearth

@bors-servo
Copy link

⌛ Testing commit bad1b50 with merge 0877b8e...

@Manishearth
Copy link
Member Author

@bors-servo r+ force clean

@Manishearth Manishearth reopened this Mar 11, 2016
@Manishearth
Copy link
Member Author

@bors-servo r+ retry

@bors-servo
Copy link

💡 This pull request was already approved, no need to approve it again.

@bors-servo
Copy link

📌 Commit bad1b50 has been approved by Manishearth

@bors-servo
Copy link

⌛ Testing commit bad1b50 with merge 079c8d8...

@Manishearth
Copy link
Member Author

@bors-servo retry clean

@Manishearth Manishearth reopened this Mar 12, 2016
@Manishearth
Copy link
Member Author

@bors-servo retry clean r+

@Manishearth
Copy link
Member Author

@bors-servo r- retry clean r+

@Manishearth Manishearth reopened this Mar 12, 2016
@Manishearth
Copy link
Member Author

@bors-servo r- clean

@Manishearth
Copy link
Member Author

@bors-servo clean r+

1 similar comment
@Manishearth
Copy link
Member Author

@bors-servo clean r+

@Manishearth Manishearth reopened this Mar 12, 2016
@Manishearth
Copy link
Member Author

@bors-servo clean r+

@bors-servo
Copy link

📌 Commit bad1b50 has been approved by Manishearth

@Manishearth
Copy link
Member Author

@bors-servo clean r-

@Manishearth
Copy link
Member Author

@bors-servo retry r+

@bors-servo
Copy link

📌 Commit bad1b50 has been approved by Manishearth

@bors-servo
Copy link

⌛ Testing commit bad1b50 with merge ca2b48a...

bors-servo pushed a commit that referenced this pull request Mar 12, 2016
Add Bluetooth device support

Moved from servo/servo#9839

r? @larsbergstrom

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/devices/1)
<!-- Reviewable:end -->
@Manishearth
Copy link
Member Author

huh. worked on its own. shrug

@bors-servo
Copy link

☀️ Test successful - travis

@bors-servo bors-servo merged commit bad1b50 into master Mar 12, 2016
@Manishearth Manishearth deleted the device-api branch March 12, 2016 02:37
SimonSapin added a commit that referenced this pull request Feb 19, 2018
Use AtomicUsize instead. Fix #1.
It behaves the same, since macOS is always 64-bit these days.

Increment the version number to 0.1.0 rather than 0.0.2
so that it is possible next time to do version number changes
that Cargo does not consider breaking.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants