Make Rect::is_empty return true when either dimension is empty #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of only returning true when both dimensions of a Rect are empty, is_empty should return true when either is empty. This makes Rect much easier to use, because applications rarely want to distinguish between situations where a Rect is empty in only one direction or both. Fixes #109.
|
@mrobinson Makes sense - r=me when you can convince travis to merge this. |
|
serde-rs/aster doesn't compile with the latest nightly |
|
Aster is back to building in 0.5.0. |
|
@bors-servo r=glennw |
|
📌 Commit 0e48edc has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Oct 18, 2015
Make Rect::is_empty return true when either dimension is empty Instead of only returning true when both dimensions of a Rect are empty, is_empty should return true when either is empty. This makes Rect much easier to use, because applications rarely want to distinguish between situations where a Rect is empty in only one direction or both. Fixes #109. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/euclid/110) <!-- Reviewable:end -->
|
☀️ Test successful - travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of only returning true when both dimensions of a Rect are
empty, is_empty should return true when either is empty. This makes
Rect much easier to use, because applications rarely want to
distinguish between situations where a Rect is empty in only one
direction or both.
Fixes #109.