This repository has been archived by the owner on Jul 10, 2023. It is now read-only.
Re-apply missing win32 patch #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @glennw |
|
@bors-servo r+ |
|
@bors-servo r=glennw |
|
📌 Commit 4f5be90 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Nov 3, 2015
Re-apply missing win32 patch This was lost in a recent rebase onto upstream master (#51). r? @vvuk <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/glutin/52) <!-- Reviewable:end -->
|
💔 Test failed - travis |
|
The failure is because some of glutin's dependencies upgraded to libc 0.2 while others (and glutin itself) are still using libc 0.1. |
|
Should we move them all to 0.2? |
|
Yes, we should make all our dependencies require libc 0.2. Currently Servo includes sixty-seven crates that depend on As a temporary measure we check in a Cargo.lock file in this repo that keeps us on libc 0.1 until everyone has updated to 0.2. |
|
#53 will fix the Travis build. |
|
Should this be retried now that #53 has merged? |
|
@bors-servo: retry |
bors-servo
pushed a commit
that referenced
this pull request
Nov 5, 2015
Re-apply missing win32 patch This was lost in a recent rebase onto upstream master (#51). r? @vvuk <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/glutin/52) <!-- Reviewable:end -->
|
☀️ Test successful - travis |
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Nov 5, 2015
Upgrade to latest glutin Includes servo/glutin#52 and servo/glutin#53. r? @glennw cc @vvuk <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8357) <!-- Reviewable:end -->
jrmuizel
pushed a commit
to jrmuizel/gecko-cinnabar
that referenced
this pull request
Jun 12, 2017
…); r=metajack Includes servo/glutin#52 and servo/glutin#53. r? @glennw cc @vvuk Source-Repo: https://github.com/servo/servo Source-Revision: 65a0bb4aefad7b1cfcce2f5d1f01b081483001e8
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 1, 2019
…); r=metajack Includes servo/glutin#52 and servo/glutin#53. r? glennw cc vvuk Source-Repo: https://github.com/servo/servo Source-Revision: 65a0bb4aefad7b1cfcce2f5d1f01b081483001e8 UltraBlame original commit: 26208474bd780eefb73abfcbf16823b1e5d9df65
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 1, 2019
…); r=metajack Includes servo/glutin#52 and servo/glutin#53. r? glennw cc vvuk Source-Repo: https://github.com/servo/servo Source-Revision: 65a0bb4aefad7b1cfcce2f5d1f01b081483001e8 UltraBlame original commit: 26208474bd780eefb73abfcbf16823b1e5d9df65
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 1, 2019
…); r=metajack Includes servo/glutin#52 and servo/glutin#53. r? glennw cc vvuk Source-Repo: https://github.com/servo/servo Source-Revision: 65a0bb4aefad7b1cfcce2f5d1f01b081483001e8 UltraBlame original commit: 26208474bd780eefb73abfcbf16823b1e5d9df65
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was lost in a recent rebase onto upstream master (#51). r? @vvuk