Skip to content
This repository has been archived by the owner on Mar 20, 2024. It is now read-only.

Add a link to the GitHub repository for queue #8

Closed
wants to merge 1 commit into from

Conversation

edunham
Copy link

@edunham edunham commented Jan 13, 2016

PR ported from 84. Originally submitted by @mrmonday on Sun Jun 14 16:01:12 2015.


This adds a link back to the GitHub repository for a project, from the queue.

Review on Reviewable

This adds a link back to the GitHub repository for a project, from the queue.
@ashcrow
Copy link

ashcrow commented Mar 29, 2016

Copying over comment from other PR...

It looks like repo_url is tied to the state and isn't available at the higher level.

I'm not familiar enough yet with the github3 library but something like this might work:

+++ b/homu/html/queue.html
@@ -30,7 +30,7 @@
         </style>
     </head>
     <body>
-        <h1>Homu queue - {{repo_label}}</h1>
+        <h1>Homu queue - {{repo_url}}</h1>

         <p>
             <button type="button" id="rollup">Create a rollup</button>
diff --git a/homu/server.py b/homu/server.py
index 25f06fa..66dd66a 100644
--- a/homu/server.py
+++ b/homu/server.py
@@ -81,6 +81,7 @@ def queue(repo_label):
         })

     return g.tpls['queue'].render(
+        repo_url = g.repos[repo_label].html_url,
         repo_label = repo_label,
         states = rows,
         oauth_client_id = g.cfg['github']['app_client_id'],

Edit: The above actually won't work as the html_url does not get set. I've proposed an alternate implementation in #25.

Manishearth pushed a commit that referenced this pull request Apr 29, 2016
This is an alternate implementation of PR #8. If the user is looking at the special "all" queue page no link will be shown.
@Eh2406
Copy link

Eh2406 commented Mar 1, 2017

Move to close

@edunham
Copy link
Author

edunham commented Mar 13, 2017

I'm trying to clear out the PR queue in order to do some refactoring. I've captured the fact that this enhancement would be nice to add eventually in #99.

@edunham edunham closed this Mar 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants