Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests fail under rust 1.77.1 to build because of rustc-test #526

Closed
rillian opened this issue Apr 2, 2024 · 1 comment · Fixed by #528
Closed

tests fail under rust 1.77.1 to build because of rustc-test #526

rillian opened this issue Apr 2, 2024 · 1 comment · Fixed by #528

Comments

@rillian
Copy link
Contributor

rillian commented Apr 2, 2024

cargo test fails to build under rust 1.77.1 because of the rustc-test transitive dependency on rustc-serialize. Looks like this is already reported upstream, but I expect the whole crate is no longer necessary and the dependency can removed.

@rillian
Copy link
Contributor Author

rillian commented Apr 2, 2024

The inclusion in xml5ever isn't used; it looks like the depending code was moved to markup5ever in 7e87faf.

It's still used in rcdom as a harness for running tests based on runtime discovery of test suite files. There are newer crates which support this, and rustc-test is also a servo project, so that could also be updated. But since it's testing the public api, I suggest just replacing it with some logging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant