Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IpcSender should consistently be Sync or !Sync. #135

Open
Ms2ger opened this issue Jan 25, 2017 · 3 comments
Open

IpcSender should consistently be Sync or !Sync. #135

Ms2ger opened this issue Jan 25, 2017 · 3 comments

Comments

@Ms2ger
Copy link
Contributor

Ms2ger commented Jan 25, 2017

It seems like it's Sync on linux and !Sync on windows right now.
@emilio
Copy link
Member

emilio commented Jan 25, 2017

yeah, that's because on windows we're using mpsc, which is out of our control. Worth waiting to #108 to land?

@antrik
Copy link
Contributor

antrik commented Feb 8, 2017

@Ms2ger it should always be !Sync after #115 -- it just hasn't landed in Servo yet. (Because of unrelated regressions in other commits...)

I'm am confused though: I did believe the version currently used in Servo should actually be Sync everywhere?... Can you please elaborate why you think that's not the case?

@Ms2ger
Copy link
Contributor Author

Ms2ger commented Feb 9, 2017

I didn't double-check, but I thought mpsc senders were not Sync? Anyway, we should land that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@antrik @Ms2ger @emilio