Run a glib main loop for the GStreamer backend #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrobinson
changed the title
mrobinson
force-pushed
the
run-main-loop
branch
from
1b99e4c
to
3b6c67b
Compare
mukilan
approved these changes
Nov 17, 2023
|
:( #407 |
mrobinson
force-pushed
the
run-main-loop
branch
from
3b6c67b
to
54fe9b0
Compare
|
Let's land this one as it deals with the client trying to create two backends at once using a synchronous OnceCell. I've added you as a co-author @ceyusa. Thank you! |
mrobinson
force-pushed
the
run-main-loop
branch
from
54fe9b0
to
8f3b86b
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
ceyusa
reviewed
Nov 18, 2023
| true | ||
| }); | ||
| } | ||
|
|
There was a problem hiding this comment.
all this has to go after line 117
This is a workaround for an issue where GStreamer does not deliver end of stream signals unless there is a main loop running. See [1] for more information. 1. #393 (comment) Co-authored-by: Víctor Manuel Jáquez Leal <vjaquez@igalia.com>
mrobinson
force-pushed
the
run-main-loop
branch
from
8f3b86b
to
68137b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for an issue where GStreamer does not deliver end
of stream signals unless there is a main loop running. See [1] for
more information.
Co-authored-by: Víctor Manuel Jáquez Leal vjaquez@igalia.com