Add HeapSizeOf support. #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
|
So that this code is built on CI, please add a line in the - ([ $TRAVIS_RUST_VERSION != nightly ] || cargo test --features heap_size) |
| @@ -83,6 +84,8 @@ pub use nth::parse_nth; | |||
| pub use serializer::{ToCss, CssStringWriter, serialize_identifier, serialize_string}; | |||
| pub use parser::{Parser, Delimiter, Delimiters, SourcePosition}; | |||
|
|
|||
| #[cfg(feature = "heap_size")] known_heap_size!(0, Color, RGBA); | |||
There was a problem hiding this comment.
Why use this over deriving the trait on the types?
|
@bors-servo r+ |
|
📌 Commit 9e84a9f has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Aug 13, 2015
Add HeapSizeOf support. Part of servo/heapsize#5. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-cssparser/85) <!-- Reviewable:end -->
|
☀️ Test successful - travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of servo/heapsize#5.