-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release a version 0.6.1 of harfbuzz
and consolidate Cargo configuration
#253
Conversation
There's no need to bump the version for cc: @Manishearth @sffc |
Some projects seems to use workspace versioning, which I think can make things a lot easier to understand for people using these crates. Here's an example: https://github.com/emilk/egui/blob/master/Cargo.toml#L23 As a person who has to upgrade a lot of dependencies, I find this easier to deal with. It's always clear what the latest version of the crate is. |
a853b65
to
0b57a69
Compare
I have updated this change to explicitly use workspace versioning, which should simplify new releases. |
That is worse.
|
harfbuzz-traits/Cargo.toml
Outdated
keywords = { workspace = true } | ||
license = { workspace = true } | ||
repository = { workspace = true } | ||
version = { workspace = true } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this shouldn't inherit, yes?
Yeah I'm not sure if we should use workspace versioning. Everything else, yes. |
…uration I managed to publish this crate without checking out the git submodules first, which breaks the `bundled` build. This version bump will ensure that the latest version on crates.io can build.
0b57a69
to
90a9b2b
Compare
harfbuzz
and consolidate Cargo configuration
I managed to publish this crate without checking out the git submodules
first, which breaks the
bundled
build. This version bump will ensurethat the latest version on crates.io can build.