Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: use NonZeroU32 for query and fragment start #933

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

DonIsaac
Copy link

Closes #930 and addresses feedback #931.

Reduces Url memory layout from 88 bytes to 80 bytes.

Copy link

codecov bot commented May 26, 2024

Codecov Report

Attention: Patch coverage is 68.00000% with 24 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@54346fa). Learn more about missing BASE report.

Files Patch % Lines
url/src/lib.rs 62.29% 23 Missing ⚠️
url/src/parser.rs 85.71% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #933   +/-   ##
=======================================
  Coverage        ?   81.78%           
=======================================
  Files           ?       21           
  Lines           ?     3574           
  Branches        ?        0           
=======================================
  Hits            ?     2923           
  Misses          ?      651           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DonIsaac
Copy link
Author

@valenting may I please have a review on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

perf: Use NonZeroU16 for port numbers
2 participants