This repository has been archived by the owner on Jul 10, 2023. It is now read-only.
Added future_frame_data, to avoid blocking the VR render thread #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #60 |
3 tasks
|
servo/servo#22938 is the matching servo PR. |
paulrouget
reviewed
Feb 26, 2019
|
Looks good to me. |
asajeffrey
force-pushed
the
future-fame-data
branch
from
2e23fb6
to
b81bb58
Compare
|
@bors-servo r=paulrouget |
1 similar comment
|
@bors-servo r=paulrouget |
|
@bors-servo r=paulrouget |
|
📌 Commit b81bb58 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Feb 26, 2019
Added future_frame_data, to avoid blocking the VR render thread At the moment, the VR render thread blocks on the VR device, waiting for the next frame. This PR makes it possible for the VR display to return a future, so the JS thread end up blocking rather than the VR render thread.
|
☀️ Test successful - checks-travis |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, the VR render thread blocks on the VR device, waiting for the next frame. This PR makes it possible for the VR display to return a future, so the JS thread end up blocking rather than the VR render thread.