Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split the macOS WPT into two chunks an add another builder #497

Merged
merged 1 commit into from Sep 30, 2016

Conversation

larsbergstrom
Copy link
Contributor

@larsbergstrom larsbergstrom commented Sep 29, 2016

r? @aneeshusa

cc @jgraham

This splits the WPT tests into two chunks, using the default strategy. The first chunk is significantly smaller than the second (900s vs 1800s, locally), so I've loaded the extra tasks onto that machine. The other chunking strategy (hash) is not yet fully supported in WPT, but we might want to go to it after this to provide more even partitioning.

I've also added a name for another mac mini builder and will probably bring such a machine online shortly.


This change is Reviewable

- ./mach build --release
- ./mach test-wpt-failure
- ./mach test-wpt --release --processes 8 --log-raw test-wpt.log --log-errorsummary wpt-errorsummary.log
- ./mach test-wpt --release --processes 8 --total-chunks 2--this-chunk 1 --log-raw test-wpt.log --log-errorsummary wpt-errorsummary.log
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a space after 2.

@larsbergstrom
Copy link
Contributor Author

Great catch - thanks!

On Thu, Sep 29, 2016 at 2:53 PM, Josh Matthews notifications@github.com
wrote:

@jdm commented on this pull request.

In buildbot/master/files/config/steps.yml
#497 (review):

  • ./mach build --release
  • ./mach test-wpt-failure
      • ./mach test-wpt --release --processes 8 --log-raw test-wpt.log --log-errorsummary wpt-errorsummary.log
      • ./mach test-wpt --release --processes 8 --total-chunks 2--this-chunk 1 --log-raw test-wpt.log --log-errorsummary wpt-errorsummary.log

Need a space after 2.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#497 (review), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAdCx6tJaxTaNg9Hx_Lzet2A2EtVYw44ks5qvBdLgaJpZM4KKZj1
.

@jgraham
Copy link
Contributor

jgraham commented Sep 29, 2016

https://bugzilla.mozilla.org/show_bug.cgi?id=1305877 is the gecko bug to improve the hash chunker fwiw.

@larsbergstrom
Copy link
Contributor Author

@notriddle I think that we could do this with Dependent schedulers (http://docs.buildbot.net/current/manual/cfg-schedulers.html#dependent-scheduler ), but I'm frankly terrified of how long it would take us to test and roll this out. Perhaps in Hawaii when we have a bunch of the team members together in one place for a bunch of hands poking at it at the same time :-)

@aneeshusa
Copy link
Contributor

r=me for manual merge, as only the macOS upgrade build is failing, which is currently expected.

@larsbergstrom, if you're setting up a new Mac builder I highly recommend

  1. Using an older revision of saltfs (i.e. before Fix Homebrew 1.0.0 fallout #483)
  2. Using salt-call on the new builder instead of salt on the master to run Salt completely locally, allowing us to use the known good older configuration.
    Ask me on IRC if you have questions about how to do that.

@larsbergstrom
Copy link
Contributor Author

Good points - thanks for the tips! I will bring the machine up first using your instructions BEFORE attempting to merge this and turn over buildbot.

@larsbergstrom
Copy link
Contributor Author

Trying to follow: https://docs.saltstack.com/en/latest/topics/tutorials/standalone_minion.html

I have a local clone of the saltfs repo, checked out at the older version of salt (and older satl installed. Getting an error now, but still working on it...

server:saltfs administrator$ sudo salt-call state.apply --local test=True
[INFO    ] Loading fresh modules for state activity
local:
    ----------
    no_|-states_|-states_|-None:
        ----------
        __run_num__:
            0
        changes:
            ----------
        comment:
            No Top file or external nodes data matches found
        name:
            No States
        result:
            False

@larsbergstrom
Copy link
Contributor Author

Aha! I needed --file-root=/Users/administrator/saltfs.

@larsbergstrom
Copy link
Contributor Author

Hrm, it's running, but I'm gonna need some stuff from the pillar (e.g., the password to connect to the buildbot)...

@larsbergstrom
Copy link
Contributor Author

Yup, got it after making a local pillar!

@larsbergstrom
Copy link
Contributor Author

Merging this manually until #492 is happy in Travis, so that I can update the buildbot master.

@aneeshusa
Copy link
Contributor

Yep, those are the two extra params needed, glad to have some extra capacity :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants