Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRe provide homebrew upload token #533
Merged
Conversation
This style avoid spurious line diff noise, since all indents are multiples of 4.
This was added to the previous `make_step` implementation, but apparently was not copied over to this implementation, causing our Homebrew uploads to fail for the last 4 days. Re-add this logic. Note that because adding the token to the environment and telling Buildbot not to log the environment are configured together, the token was not leaked during this time.
|
cc @paulrouget |
|
@bors-servo r+ |
|
|
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 31, 2016
…rsbergstrom Re provide homebrew upload token This was added to the previous `make_step` implementation, but apparently was not copied over to this implementation, causing our Homebrew uploads to fail for the last 4 days. Re-add this logic. Note that because adding the token to the environment and telling Buildbot not to log the environment are configured together, the token was not leaked during this time. r? @larsbergstrom Fixes #532. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/533) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
aneeshusa commentedOct 31, 2016
•
edited by larsbergstrom
This was added to the previous
make_stepimplementation,but apparently was not copied over to this implementation,
causing our Homebrew uploads to fail for the last 4 days.
Re-add this logic.
Note that because adding the token to the environment and telling
Buildbot not to log the environment are configured together,
the token was not leaked during this time.
r? @larsbergstrom
Fixes #532.
This change is