Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle th tag as HTMLTableCellElement. #1060 #1061

Merged
merged 1 commit into from Oct 15, 2013

Conversation

tetsuharuohzeki
Copy link
Contributor

No description provided.

@larsbergstrom
Copy link
Contributor

This looks correct, per http://www.w3.org/TR/CSS2/tables.html, section 17.2.

@bors-servo bors-servo merged commit 31b8737 into servo:master Oct 15, 2013
@Ms2ger
Copy link
Contributor

Ms2ger commented Oct 15, 2013

This looks correct, per http://www.w3.org/TR/CSS2/tables.html, section 17.2.

Uh, what's that got to do with anything?

@jgraham
Copy link
Contributor

jgraham commented Oct 15, 2013

This is wrong. The HTML spec (not CSS) is the correct reference for the interfaces implemented by various tags and in this case it should be HTMLTableHeaderCellElement [1]

[1] http://www.whatwg.org/specs/web-apps/current-work/multipage/tabular-data.html#the-th-element

@jgraham
Copy link
Contributor

jgraham commented Oct 15, 2013

(fwiw Ms2ger pointed out that other browsers don't implement the extra stuff on <th> compared to <td>. Nevertheless I feel we ought to try this in servo and see if it's web compatible or, if we think that is too big a risk, get the spec changed because then no one else with more to lose will take the risk either)

@tetsuharuohzeki
Copy link
Contributor Author

I'm sorry. It's my careless miss.

OK. I'll create the backout commit and implement their interfaces.

@larsbergstrom
Copy link
Contributor

No, my fault for using the wrong resource.

@tetsuharuohzeki
Copy link
Contributor Author

Oh, I worked them at #1063:

  • I didn't backout this pullrequest.
  • I added webidl files of HTMLTableDataCellElement & HTMLTableHeaderCellElement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants