Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support form submission of multipart/form-data #10712

Merged
merged 4 commits into from May 1, 2016
Merged

Support form submission of multipart/form-data #10712

merged 4 commits into from May 1, 2016

Conversation

KiChjang
Copy link
Contributor

Fixes #7553.

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/lib.rs, components/script/Cargo.toml, components/script/dom/htmlformelement.rs, components/script/dom/htmlselectelement.rs, components/script/dom/htmlinputelement.rs

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Apr 19, 2016
@highfive
Copy link

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!

@KiChjang
Copy link
Contributor Author

@bors-servo try

@bors-servo
Copy link
Contributor

⌛ Trying commit 9b35e2c with merge baedca1...

bors-servo pushed a commit that referenced this pull request Apr 19, 2016
Auto merge of #10712 - KiChjang:multipart-form-data, r=<try>
baedca1 
Support form submission of multipart/form-data

Fixes #7553.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10712)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - mac-rel-wpt

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Apr 19, 2016
@highfive highfive removed the S-tests-failed The changes caused existing tests to fail. label Apr 19, 2016
@jdm
Copy link
Member

jdm commented Apr 19, 2016

Looks like no WPT tests changed results; what's the test plan here?

@KiChjang
Copy link
Contributor Author

I'm very surprised that no new WPT tests pass, I'm guessing I must be doing something wrong in this PR.

@KiChjang
Copy link
Contributor Author

Ah wait, it's because there aren't any consumers of the functionality yet.

@bors-servo
Copy link
Contributor

☔ The latest upstream changes (presumably #10750) made this pull request unmergeable. Please resolve the merge conflicts.

@highfive highfive added the S-needs-rebase There are merge conflict errors. label Apr 20, 2016
@KiChjang
Copy link
Contributor Author

I'm tempted to also implement submit as body action for forms just to make tests for this, but this'll have to wait until saturday or later since I have final exams and I have some moving to do.

@KiChjang KiChjang removed the S-needs-rebase There are merge conflict errors. label Apr 24, 2016
@KiChjang KiChjang added the S-needs-tests New tests have been requested by a reviewer. label Apr 25, 2016
KiChjang
KiChjang reviewed Apr 25, 2016
View reviewed changes
tests/wpt/web-platform-tests/html/semantics/forms/form-submission-0/resources/url-encoded.py
if request.body == "foo=bara":
return [("Content-Type", "text/plain")], "OK"
else:
return [("Content-Type", "text/plain")], "FAIL"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work right now - it keeps on returning "Unknown content type (application/json)" to the iframe. Not sure what's wrong here...

@Ms2ger
Copy link
Contributor

Ms2ger commented Apr 25, 2016

Review status: 0 of 11 files reviewed at latest revision, 3 unresolved discussions.

tests/wpt/web-platform-tests/html/semantics/forms/form-submission-0/submit-entity-body.html, line 21 [r5] (raw file):
var

tests/wpt/web-platform-tests/html/semantics/forms/form-submission-0/submit-entity-body.html, line 39 [r5] (raw file):
I don't think it's guaranteed that this line of JS will execute before the load event has been dispatched; try putting the iframe after the script and using the onload content attribute in markup.

Comments from Reviewable

@bors-servo
Copy link
Contributor

☔ The latest upstream changes (presumably #10833) made this pull request unmergeable. Please resolve the merge conflicts.

@highfive highfive added the S-needs-rebase There are merge conflict errors. label Apr 25, 2016
@KiChjang KiChjang force-pushed the multipart-form-data branch 2 times, most recently from 3105c6a to e9f6b83 Compare April 25, 2016 22:35
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels May 1, 2016
@bors-servo
Copy link
Contributor

⌛ Testing commit 538e24c with merge 670ecf0...

bors-servo pushed a commit that referenced this pull request May 1, 2016
Auto merge of #10712 - KiChjang:multipart-form-data, r=jdm
670ecf0 
Support form submission of multipart/form-data

Fixes #7553.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10712)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-dev

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels May 1, 2016
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels May 1, 2016
@KiChjang
Copy link
Contributor Author

KiChjang commented May 1, 2016

@bors-servo r=jdm

@bors-servo
Copy link
Contributor

📌 Commit 3110647 has been approved by jdm

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels May 1, 2016
@bors-servo
Copy link
Contributor

⌛ Testing commit 3110647 with merge 77cb2ca...

bors-servo pushed a commit that referenced this pull request May 1, 2016
Auto merge of #10712 - KiChjang:multipart-form-data, r=jdm
77cb2ca 
Support form submission of multipart/form-data

Fixes #7553.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10712)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - mac-rel-wpt

@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label May 1, 2016
@highfive
Copy link

highfive commented May 1, 2016 

  ▶ CRASH [expected OK] /XMLHttpRequest/response-data-arraybuffer.htm

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label May 1, 2016
@KiChjang
Copy link
Contributor Author

KiChjang commented May 1, 2016 •
edited

@bors-servo retry

@bors-servo
Copy link
Contributor

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css are reusable. Rebuilding only mac-rel-wpt, windows...

@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows

@bors-servo bors-servo merged commit 3110647 into servo:master May 1, 2016
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label May 1, 2016
@KiChjang KiChjang deleted the multipart-form-data branch May 1, 2016 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-tests-failed The changes caused existing tests to fail.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@KiChjang @highfive @bors-servo @jdm @Ms2ger @glennw @psdh