Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the svgevents argument to Document::createEvent #10814

Merged
merged 1 commit into from Apr 25, 2016
Merged

Implement the svgevents argument to Document::createEvent #10814

merged 1 commit into from Apr 25, 2016

Conversation

SunyDays
Copy link

close #10741

This change is Reviewable

@highfive
Copy link

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon.

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/document.rs

@highfive
Copy link

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Apr 22, 2016
@frewsxcv frewsxcv mentioned this pull request Apr 23, 2016
Merged
@Ms2ger
Copy link
Contributor

Ms2ger commented Apr 24, 2016

Lgtm, but we'll need some expectation changes; see tests/wpt/README.md. Let me know if you need help with that.

@bors-servo try

@bors-servo
Copy link
Contributor

⌛ Trying commit 4f38482 with merge b4175ba...

bors-servo pushed a commit that referenced this pull request Apr 24, 2016
Auto merge of #10814 - SunyDays:svgevents_argument, r=<try>
b4175ba 
Implement the svgevents argument to Document::createEvent

close #10741

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10814)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - mac-rel-wpt

@highfive
Copy link 

  ▶ Unexpected subtest result in /dom/nodes/Document-createEvent.html:
  └ PASS [expected FAIL] SVGEvents should be an alias for Event.

  ▶ Unexpected subtest result in /dom/nodes/Document-createEvent.html:
  └ PASS [expected FAIL] createEvent(&#39;SVGEvents&#39;) should be initialized correctly.

  ▶ Unexpected subtest result in /dom/nodes/Document-createEvent.html:
  └ PASS [expected FAIL] svgevents should be an alias for Event.

  ▶ Unexpected subtest result in /dom/nodes/Document-createEvent.html:
  └ PASS [expected FAIL] createEvent(&#39;svgevents&#39;) should be initialized correctly.

  ▶ Unexpected subtest result in /dom/nodes/Document-createEvent.html:
  └ PASS [expected FAIL] SVGEVENTS should be an alias for Event.

  ▶ Unexpected subtest result in /dom/nodes/Document-createEvent.html:
  └ PASS [expected FAIL] createEvent(&#39;SVGEVENTS&#39;) should be initialized correctly.

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Apr 24, 2016
@Ms2ger
Copy link
Contributor

Ms2ger commented Apr 24, 2016

You should remove the parts of the ini file that match those newly passing tests.

@highfive highfive removed the S-tests-failed The changes caused existing tests to fail. label Apr 24, 2016
@KiChjang
Copy link
Contributor

@bors-servo r=Ms2ger

@bors-servo
Copy link
Contributor

📌 Commit bb19e7d has been approved by Ms2ger

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Apr 24, 2016
@bors-servo
Copy link
Contributor

⌛ Testing commit bb19e7d with merge 4b8f126...

bors-servo pushed a commit that referenced this pull request Apr 25, 2016
Auto merge of #10814 - SunyDays:svgevents_argument, r=Ms2ger
4b8f126 
Implement the svgevents argument to Document::createEvent

close #10741

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10814)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt

@bors-servo bors-servo merged commit bb19e7d into servo:master Apr 25, 2016
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 25, 2016
@SunyDays SunyDays deleted the svgevents_argument branch April 25, 2016 08:50
@SunyDays SunyDays restored the svgevents_argument branch April 25, 2016 08:51
@SunyDays SunyDays deleted the svgevents_argument branch April 25, 2016 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement the "svgevents" argument to Document::createEvent
7 participants
@SunyDays @highfive @Ms2ger @bors-servo @KiChjang @Manishearth @MrSunyDays