Implement the errorevent argument to Document::createEvent #10816

SunyDays · 2016-04-23T01:01:06Z

new_uninitialized function on ErrorEvent has already been in components/script/dom/errorevent.rs

This change is

highfive · 2016-04-23T01:01:10Z

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @metajack (or someone else) soon.

highfive · 2016-04-23T01:01:11Z

Heads up! This PR modifies the following files:

@KiChjang: components/script/dom/document.rs

highfive · 2016-04-23T01:01:12Z

Warning

These commits modify script code, but no tests are modified. Please consider adding a test!

jdm · 2016-04-23T01:07:14Z

Thanjs for the PR! In the future, please leave a comment in issues before starting to work on them. It avoids any chance that multiple people accidentally work on an issue at the same time.

SunyDays · 2016-04-23T11:13:55Z

Ok!

frewsxcv · 2016-04-23T23:35:15Z

It looks like this pull request also includes #10814. Either remove that commit in this pull request, or just close the other issue and combine them into this one.

frewsxcv · 2016-04-24T12:23:50Z

components/script/dom/document.rs

@@ -2168,6 +2169,8 @@ impl DocumentMethods for Document {
                        &TouchList::new(&self.window, &[]),
                    )
                )),
+            "errorevent" =>
+                Ok(Root::upcast(ErrorEvent::new_uninitialized(GlobalRef::Window(&self.window)))),


There's a + at the beginning of this line

frewsxcv · 2016-04-24T17:31:08Z

Looks good! Can you squash your commits?

SunyDays · 2016-04-24T17:55:19Z

@frewsxcv, done!

frewsxcv · 2016-04-24T17:56:24Z

Sorry, one more thing. Can you retitle the commit from "squash commits" to "Implement the errorevent argument to Document::createEvent" or something more meaningful?

SunyDays · 2016-04-24T18:03:58Z

@frewsxcv, of course

frewsxcv · 2016-04-24T18:38:38Z

Thanks for your contribution! 🎉

@bors-servo r+

bors-servo · 2016-04-24T18:38:40Z

📌 Commit b910db3 has been approved by frewsxcv

bors-servo · 2016-04-24T18:38:42Z

⌛ Testing commit b910db3 with merge 2862f9b...

Implement the errorevent argument to Document::createEvent new_uninitialized function on ErrorEvent has already been in components/script/dom/errorevent.rs close #10738  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10816)

bors-servo · 2016-04-24T19:20:55Z

💔 Test failed - mac-rel-wpt

highfive · 2016-04-24T19:20:57Z

  ▶ Unexpected subtest result in /workers/Worker_dispatchEvent_ErrorEvent.htm:
  │ FAIL [expected PASS] document.createEvent(&#39;ErrorEvent&#39;)
  │   → assert_throws: should not be supported function &#34;function () {
    document.createEvent(&#34;ErrorEvent&#34;);
  }&#34; did not throw
  │ 
  │ @http://web-platform.test:8000/workers/Worker_dispatchEvent_ErrorEvent.htm:22:1
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1397:20
  │ test@http://web-platform.test:8000/resources/testharness.js:495:9
  └ @http://web-platform.test:8000/workers/Worker_dispatchEvent_ErrorEvent.htm:21:1

frewsxcv · 2016-04-24T20:06:02Z

This now depends on web-platform-tests/wpt#2890.

bors-servo · 2016-04-25T10:31:50Z

☔ The latest upstream changes (presumably #10819) made this pull request unmergeable. Please resolve the merge conflicts.

bors-servo · 2016-04-26T23:40:59Z

⌛ Testing commit bacb1c7 with merge 4456715...

Implement the errorevent argument to Document::createEvent new_uninitialized function on ErrorEvent has already been in components/script/dom/errorevent.rs close #10738  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10816)

bors-servo · 2016-04-27T00:50:50Z

💔 Test failed - linux-rel

highfive · 2016-04-27T00:50:53Z

  ▶ Unexpected subtest result in /workers/Worker_dispatchEvent_ErrorEvent.htm:
  └ PASS [expected FAIL] document.createEvent(&#39;ErrorEvent&#39;)

frewsxcv · 2016-04-27T00:51:40Z

Cool, looks like you need to mark that test as passing now 👍

bors-servo · 2016-04-27T01:40:56Z

☔ The latest upstream changes (presumably #10820) made this pull request unmergeable. Please resolve the merge conflicts.

SunyDays · 2016-04-27T13:15:15Z

@frewsxcv, I can't find where to mark that test as passing

frewsxcv · 2016-04-27T13:17:05Z

https://github.com/servo/servo/blob/master/tests/wpt/metadata/workers/Worker_dispatchEvent_ErrorEvent.htm.ini

Though, you should really be using ./mach test-wpt and ./mach update-wpt as per this document: https://github.com/servo/servo/blob/master/tests/wpt/README.md#updating-test-expectations

frewsxcv · 2016-04-27T17:43:31Z

@SunyDays Can you squash :) Sorry for all these steps

SunyDays · 2016-04-27T17:51:50Z

@frewsxcv, oh yes, I really sorry that i forgot it

frewsxcv · 2016-04-27T17:52:33Z

Thanks again!

@bors-servo r+

bors-servo · 2016-04-27T17:52:38Z

📌 Commit 7d24426 has been approved by frewsxcv

bors-servo · 2016-04-27T17:52:39Z

📌 Commit 7d24426 has been approved by frewsxcv

Implement the errorevent argument to Document::createEvent new_uninitialized function on ErrorEvent has already been in components/script/dom/errorevent.rs close #10738  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10816)

bors-servo · 2016-04-27T17:52:42Z

⌛ Testing commit 7d24426 with merge 311dd0f...

bors-servo · 2016-04-27T19:12:01Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt

highfive assigned metajack Apr 23, 2016

highfive added the S-awaiting-review There is new code that needs to be reviewed. label Apr 23, 2016

frewsxcv reviewed Apr 24, 2016
View reviewed changes

frewsxcv assigned frewsxcv and unassigned metajack Apr 24, 2016

highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Apr 24, 2016

highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 24, 2016

highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 24, 2016

highfive added the S-tests-failed The changes caused existing tests to fail. label Apr 24, 2016

frewsxcv added S-blocked-on-external Something, somewhere else, needs to happen before this PR can be merged. and removed S-tests-failed The changes caused existing tests to fail. labels Apr 24, 2016

highfive added the S-needs-rebase There are merge conflict errors. label Apr 25, 2016

highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 26, 2016

highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Apr 27, 2016

highfive added the S-needs-rebase There are merge conflict errors. label Apr 27, 2016

highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Apr 27, 2016

Implement the errorevent argument to Document::createEvent

7d24426

highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. S-needs-rebase There are merge conflict errors. labels Apr 27, 2016

bors-servo merged commit 7d24426 into servo:master Apr 27, 2016

highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 27, 2016

SunyDays deleted the errorevent_argument branch April 27, 2016 19:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement the errorevent argument to Document::createEvent #10816

Implement the errorevent argument to Document::createEvent #10816

SunyDays commented Apr 23, 2016

highfive commented Apr 23, 2016

highfive commented Apr 23, 2016

highfive commented Apr 23, 2016

jdm commented Apr 23, 2016

SunyDays commented Apr 23, 2016

frewsxcv commented Apr 23, 2016

frewsxcv Apr 24, 2016

frewsxcv commented Apr 24, 2016

SunyDays commented Apr 24, 2016

frewsxcv commented Apr 24, 2016

SunyDays commented Apr 24, 2016

frewsxcv commented Apr 24, 2016

bors-servo commented Apr 24, 2016

bors-servo commented Apr 24, 2016

bors-servo commented Apr 24, 2016

highfive commented Apr 24, 2016

frewsxcv commented Apr 24, 2016

bors-servo commented Apr 25, 2016

bors-servo commented Apr 26, 2016

bors-servo commented Apr 27, 2016

highfive commented Apr 27, 2016

frewsxcv commented Apr 27, 2016

bors-servo commented Apr 27, 2016

SunyDays commented Apr 27, 2016

frewsxcv commented Apr 27, 2016 •

edited by larsbergstrom

frewsxcv commented Apr 27, 2016

SunyDays commented Apr 27, 2016

frewsxcv commented Apr 27, 2016 •

edited by larsbergstrom

bors-servo commented Apr 27, 2016

bors-servo commented Apr 27, 2016

bors-servo commented Apr 27, 2016

bors-servo commented Apr 27, 2016

Implement the errorevent argument to Document::createEvent #10816

Implement the errorevent argument to Document::createEvent #10816

Conversation

SunyDays commented Apr 23, 2016

highfive commented Apr 23, 2016

highfive commented Apr 23, 2016

highfive commented Apr 23, 2016

jdm commented Apr 23, 2016

SunyDays commented Apr 23, 2016

frewsxcv commented Apr 23, 2016

frewsxcv Apr 24, 2016

Choose a reason for hiding this comment

frewsxcv commented Apr 24, 2016

SunyDays commented Apr 24, 2016

frewsxcv commented Apr 24, 2016

SunyDays commented Apr 24, 2016

frewsxcv commented Apr 24, 2016

bors-servo commented Apr 24, 2016

bors-servo commented Apr 24, 2016

bors-servo commented Apr 24, 2016

highfive commented Apr 24, 2016

frewsxcv commented Apr 24, 2016

bors-servo commented Apr 25, 2016

bors-servo commented Apr 26, 2016

bors-servo commented Apr 27, 2016

highfive commented Apr 27, 2016

frewsxcv commented Apr 27, 2016

bors-servo commented Apr 27, 2016

SunyDays commented Apr 27, 2016

frewsxcv commented Apr 27, 2016 • edited by larsbergstrom

frewsxcv commented Apr 27, 2016

SunyDays commented Apr 27, 2016

frewsxcv commented Apr 27, 2016 • edited by larsbergstrom

bors-servo commented Apr 27, 2016

bors-servo commented Apr 27, 2016

bors-servo commented Apr 27, 2016

bors-servo commented Apr 27, 2016

frewsxcv commented Apr 27, 2016 •

edited by larsbergstrom

frewsxcv commented Apr 27, 2016 •

edited by larsbergstrom