Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On desktop, use the same app icon we use on Android #11199

Merged
merged 3 commits into from May 16, 2016
Merged

On desktop, use the same app icon we use on Android #11199

merged 3 commits into from May 16, 2016

Conversation

nox
Copy link
Contributor

@nox nox commented May 16, 2016

This change is Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label May 16, 2016
@nox
Copy link
Contributor Author

nox commented May 16, 2016

@bors-servo r=metajack

@bors-servo
Copy link
Contributor

📌 Commit dab6935 has been approved by metajack

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels May 16, 2016
@bors-servo
Copy link
Contributor

⌛ Testing commit dab6935 with merge 7cdb9fd...

bors-servo pushed a commit that referenced this pull request May 16, 2016
On desktop, use the same app icon we use on Android

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11199)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-dev

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels May 16, 2016
This makes the app easier to pick out in Instruments.app and so forth.
@highfive
Copy link

New code was committed to pull request.

@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels May 16, 2016
@nox
Copy link
Contributor Author

nox commented May 16, 2016

Tidy was unhappy.

@bors-servo r=metajack

@bors-servo
Copy link
Contributor

📌 Commit 981ad2d has been approved by metajack

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels May 16, 2016
@bors-servo
Copy link
Contributor

⌛ Testing commit 981ad2d with merge 66acb10...

bors-servo pushed a commit that referenced this pull request May 16, 2016
On desktop, use the same app icon we use on Android

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11199)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows

@bors-servo bors-servo merged commit 981ad2d into master May 16, 2016
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label May 16, 2016
This was referenced May 16, 2016
@Ms2ger Ms2ger deleted the icon branch May 23, 2016 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants